-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iconograpy page tag buttons #1693
Open
AndrewKeepCoding
wants to merge
16
commits into
microsoft:main
Choose a base branch
from
AndrewKeepCoding:iconograpy-page-tag-buttons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Iconograpy page tag buttons #1693
AndrewKeepCoding
wants to merge
16
commits into
microsoft:main
from
AndrewKeepCoding:iconograpy-page-tag-buttons
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the icon name is already at the top of the pane, remove this to get vertical space so the tags can be visible by default.
3 tasks
niels9001
requested changes
Dec 15, 2024
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add "tag" buttons to the icon details pane on the "Iconography" page. When the "tag" button is clicked, the "tag" will be set to the icon search box to filter icons by the "tag" text.
This PR will also update the placeholder on the icon search box to "Search icons by name, code, tags...".
Motivation and Context
How Has This Been Tested?
Tested on VS.
Screenshots (if appropriate):
Types of changes