Make sure commandline options are absolute paths so they dont conflict with options from tsbuild info #34403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
sandersn,
weswigham,
andrewbranch,
elibarzilay,
orta,
rbuckton and
RyanCavanaugh
|
Argh, thanks, I was just coming back to that PR this morning! |
orta
approved these changes
Oct 15, 2019
sandersn
approved these changes
Oct 15, 2019
| ); | ||
| } | ||
| } | ||
| if (result.configFilePath) { |
There was a problem hiding this comment.
doesn't the main loop already run toAbsolutePath on configFilePath with all the other properties?
There was a problem hiding this comment.
configFilePath is not in optionDeclarations so it wont get normalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33667 and #30457
Picked up from #32992