Add support for taking relative CLI args and using them as absolute internally #32992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested changes
Aug 20, 2019
…or additional args
sheetalkamat
requested changes
Aug 20, 2019
|
OK @sheetalkamat - I think I've got your feedback covered, sorry for the delay! |
sheetalkamat
requested changes
Sep 16, 2019
| @@ -2541,7 +2542,16 @@ namespace ts { | |||
| for (const id in jsonOptions) { | |||
| const opt = optionNameMap.get(id); | |||
| if (opt) { | |||
| defaultOptions[opt.name] = convertJsonOption(opt, jsonOptions[id], basePath, errors); | |||
|
|
|||
There was a problem hiding this comment.
This change is incorrect... You want do want to use convertJsonOption as was earlier here and combine the basePath with the nonrooted Paths as this is an API entry point and you cannot use sys.getCurrentDirectory() here..
The suggestedChange I recommended was to call convertOptionsFromJson with basePath as sys.getCurrentDirectory()
|
Deprecated by #34403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30457
The idea here is that after
parseCommandLineWorkerhas done its work and before it is used for compilation - any relative paths are re-defined as absolute when the CLI options are merged with a tsconfig. Making the example issues in #30457 pass.