Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1722 add ssn support #2025

Merged
merged 42 commits into from
May 24, 2024
Merged

1722 add ssn support #2025

merged 42 commits into from
May 24, 2024

Conversation

thomasyopes
Copy link
Contributor

@thomasyopes thomasyopes commented May 6, 2024 •
edited

Ticket: #1722

Description

  • Uncommented / renamed general types in core and adjusted PI schema
  • Added mirror general types to api-sdk and adjusted PI schema (and DTO schema mirroring core)
  • adjusted conversion functions for CW + CQ (FHIR) to allow general type lookup. Note: non-drivers license it skipped for CW still.
  • Removed duplicate personal identifier type from api that was already present in core + api-sdk
  • Had utils/fhir-migration import from core/external/fhir/patient
  • Moved gender at birth mapping function to domain/patient (from core/external/fhir/patient)

Testing

  • Local
    • Created user with SSN
    • Updated user with SSN
    • Run CW PD flow
    • Run CQ PD flow
  • Staging
    • Create user with SSN
    • Update user with SSN
  • Production
    • Create user with SSN (runs CW / CQ)
    • Update user with SSN (runs CW / CQ)

Release Plan

  • Publish NPM Packages
  • Merge this

@thomasyopes thomasyopes linked an issue May 6, 2024 that may be closed by this pull request
Add SSN support #1722
Closed
leite08
leite08 reviewed May 7, 2024
View reviewed changes
packages/api-sdk/src/medical/models/demographics.ts Outdated Show resolved Hide resolved
packages/core/src/domain/patient.ts Outdated Show resolved Hide resolved
packages/utils/src/fhir-migration.ts Outdated Show resolved Hide resolved
packages/api/src/routes/medical/schemas/patient.ts Outdated Show resolved Hide resolved
@thomasyopes thomasyopes requested a review from leite08 May 7, 2024 16:54
@thomasyopes thomasyopes requested a review from jonahkaye May 7, 2024 23:02
@thomasyopes thomasyopes requested a review from leite08 May 10, 2024 20:23
leite08
leite08 approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thomasyopes thomasyopes requested a review from leite08 May 15, 2024 21:20
leite08
leite08 previously approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@leite08 leite08 dismissed their stale review May 15, 2024 23:08

Forgot we need to update the release plan to publish NPM packages

@thomasyopes thomasyopes requested a review from leite08 May 15, 2024 23:21
@thomasyopes thomasyopes removed a link to an issue May 22, 2024
Add SSN support #1722
Closed
@thomasyopes
Copy link
Contributor Author

🚀

I did NPM packages.

@thomasyopes thomasyopes added this pull request to the merge queue May 24, 2024
Merged via the queue into develop with commit d7389e7 May 24, 2024
32 of 33 checks passed
@thomasyopes thomasyopes deleted the 1722-add-ssn-support branch May 24, 2024 15:15
This was referenced May 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leite08 leite08 leite08 approved these changes

@jonahkaye jonahkaye jonahkaye approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasyopes @leite08 @jonahkaye