1634 E2E tests #2053

leite08 · 2024-05-09T01:58:38Z

Ticket: https://github.com/metriport/metriport-internal/issues/1634

Dependencies

Upstream: 1634 Move E2E tests to root of packages/api #2055
Downstream: 1040 Move errors and env-var from core to shared #2112

Description

V1 of E2E tests in production:

gets an organization
updates an organization
creates a facility
gets a facility
updates a facility
creates and gets the patient
awaits patient update to be replicated
creates consolidated data
counts consolidated data
returns consolidated data
triggers a conversion of consolidated into HTML format
completes conversion successfully
triggers a document query
gets successful response from document query
contains expected data on FHIR server
deletes a patient's consolidated data
deletes the patient
deletes the facility

Those tests are the first iteration of the E2E tests in production. For the complete list please refer to the ticket.

Testing

Local
- E2E tests run
Staging
- E2E tests run
Sandbox
- E2E tests run
Production
- E2E tests run

Release Plan

leite08 · 2024-05-18T21:51:40Z

.github/workflows/a-wip-test-e2e.yml

This was used to test the intermittent execution of E2E tests, which is not an issue anymore (after we removed the release step).

leite08 · 2024-05-18T21:52:57Z

.github/workflows/_e2e-tests.yml

@@ -88,7 +86,6 @@ jobs:
 working-directory: "./"
 env:
 TEST_API_KEY: ${{ secrets.TEST_API_KEY }}
- TEST_ACC_ID: ${{ secrets.TEST_ACC_ID }}


Removed as its not used anywhere

leite08 · 2024-05-18T23:42:15Z

packages/api/src/__tests__/e2e/mapi/patient.ts

+ firstName: "Junhdjjdkksuyujebeb",
+ lastName: "Xamuscaeyttyworo",
+ dob: "1900-01-01",


Fixing to something that won't have a match

leite08 · 2024-05-18T23:43:07Z

packages/api/src/__tests__/e2e/shared.ts

@@ -12,7 +12,7 @@ export const testApiKey = getEnvVarOrFail("TEST_API_KEY");
 export const baseURL = getEnvVarOrFail("API_URL");

 export const api = Axios.create({
- timeout: 10_000,
+ timeout: 20_000,


Try to avoid the timeout from FHIR server to search by org name

leite08 · 2024-05-18T23:43:39Z

packages/api/src/__tests__/env-setup.ts

+dotenv.config({ path: path.resolve(...paths, ".env") });
 dotenv.config({ path: path.resolve(...paths, ".env.test") });


This prioritizes the .env local if available

leite08 · 2024-05-18T23:44:08Z

packages/api/src/domain/medical/__tests__/document-query.ts

@@ -22,6 +22,6 @@ export function makeDocumentQueryProgress(
 return {
 download: makeProgress(seed.download),
 convert: makeProgress(seed.convert),
- requestId: seed.requestId === null ? undefined : seed.requestId ?? faker.datatype.uuid(),
+ requestId: seed.requestId === null ? undefined : seed.requestId ?? faker.string.uuid(),


Replace the deprecated version

Orta21 · 2024-05-23T15:30:17Z

packages/api/src/external/commonwell/patient.ts

+ patient: Patient,
+ facilityId: string
+): Promise<CommonwellPatient | undefined> {
+ const { debug } = Util.out(`CW get - M patientId ${patient.id}`);


Seems to be using the deprecated Util.Out

I was following the other functions on the same file, but updated them all to use the active one. 👍

Orta21 · 2024-05-23T15:32:02Z

packages/api/src/external/commonwell/patient.ts

+ facilityId,
+ debug,
+ });
+ if (!cwEnabled) return undefined;


I know this function isnt being used yet but it would help to add a log here so we can better diagnose if we didnt get anyting when its in prod

The other endpoints don't log directly, they all do through validateCWEnabled().

Ref. metriport/metriport-internal#1634

- WIP simplified e2e test - add "Run E2E test" GH workflow to be run manually Ref. metriport/metriport-internal#1634

Ref. metriport/metriport-internal#1634

Ref. metriport/metriport-internal#1634 Signed-off-by: Rafael Leite <[email protected]>

Ref: #000 - [email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected] - @metriport/[email protected] - @metriport/[email protected] - [email protected]

leite08 force-pushed the 1634-improve-e2e-tests branch from a0dda34 to 0717eac Compare May 9, 2024 02:00

Base automatically changed from 1634-add-manual-e2e-test-to-cicd to develop May 9, 2024 14:14

leite08 changed the base branch from develop to 1634-move-e2e-tests May 9, 2024 14:23

leite08 force-pushed the 1634-improve-e2e-tests branch from 0717eac to 16c3f2e Compare May 9, 2024 14:23

leite08 temporarily deployed to staging May 9, 2024 14:26 — with GitHub Actions Inactive

leite08 force-pushed the 1634-improve-e2e-tests branch 2 times, most recently from 565c9e0 to e5cd64a Compare May 14, 2024 00:45

leite08 had a problem deploying to staging May 14, 2024 04:45 — with GitHub Actions Failure

leite08 mentioned this pull request May 15, 2024

1040 Move errors and env-var from core to shared #2084

Closed

3 tasks

leite08 had a problem deploying to staging May 15, 2024 01:16 — with GitHub Actions Failure

leite08 had a problem deploying to staging May 15, 2024 02:20 — with GitHub Actions Failure

leite08 force-pushed the 1634-move-e2e-tests branch from 0289925 to 0f43822 Compare May 17, 2024 03:33

leite08 temporarily deployed to staging May 18, 2024 21:26 — with GitHub Actions Inactive

leite08 changed the title ~~1634 WIP improve e2e tests~~ 1634 E2E tests May 18, 2024

leite08 commented May 18, 2024

View reviewed changes

leite08 force-pushed the 1634-move-e2e-tests branch from 0f43822 to c444a2f Compare May 18, 2024 21:54

leite08 force-pushed the 1634-improve-e2e-tests branch from 73c9258 to 96102ff Compare May 18, 2024 22:22

leite08 temporarily deployed to staging May 18, 2024 22:23 — with GitHub Actions Inactive

leite08 force-pushed the 1634-improve-e2e-tests branch from 7209e71 to c5857ab Compare May 18, 2024 23:41

leite08 commented May 18, 2024

View reviewed changes

leite08 force-pushed the 1634-improve-e2e-tests branch 2 times, most recently from c4636f9 to 734213c Compare May 18, 2024 23:48

leite08 had a problem deploying to staging May 19, 2024 00:04 — with GitHub Actions Failure

leite08 force-pushed the 1634-improve-e2e-tests branch from 07f78cc to ddcd5b2 Compare May 19, 2024 00:13

leite08 had a problem deploying to staging May 19, 2024 00:14 — with GitHub Actions Error

leite08 temporarily deployed to staging May 19, 2024 00:14 — with GitHub Actions Inactive

Orta21 reviewed May 23, 2024

View reviewed changes

Orta21 approved these changes May 23, 2024

View reviewed changes

leite08 force-pushed the 1634-improve-e2e-tests branch from 9463176 to 84f745b Compare May 24, 2024 22:20

leite08 added 19 commits May 27, 2024 15:01

build: wip draft of changes WIP

7e84ebb

Ref. metriport/metriport-internal#1634

build: adjust cicd test

4024ab6

Ref. metriport/metriport-internal#1634

build: wip simplified e2e test +

c287d18

- WIP simplified e2e test - add "Run E2E test" GH workflow to be run manually Ref. metriport/metriport-internal#1634

build: simplified e2e test

469461a

Ref. metriport/metriport-internal#1634

feat(api): add facility delete endpoint

84fc757

Ref. metriport/metriport-internal#1634

feat(docs): add facility delete endpoint

a97b2b1

Ref. metriport/metriport-internal#1634

feat(sdk): add facility delete endpoint to Fern definition

76b1b48

Ref. metriport/metriport-internal#1634

build: wrap HAPI error on PUT consolidated

bd42a1e

Ref. metriport/metriport-internal#1634

build: tmp disable delete facility e2e test

80b4654

Ref. metriport/metriport-internal#1634

build: fix makeDocRef test payload (no localhost on payload)

b6be320

Ref. metriport/metriport-internal#1634

build: request logger only uses alphanumeric chars for req id

da8b843

Ref. metriport/metriport-internal#1634

feat(api): add unit test for facility delete

b78e82f

Ref. metriport/metriport-internal#1634

fix(api): fix import and adjust e2e test name

70999f6

Ref. metriport/metriport-internal#1634

build: reenables delete facility on e2e test

f83b611

Ref. metriport/metriport-internal#1634

fix: jest env type to dev instead of development

48ebb99

Ref. metriport/metriport-internal#1634

fix(api): e2e add wait after put consolidated

0c34a85

Ref. metriport/metriport-internal#1634

fix(api): fix bad merge

075fd8f

Ref. metriport/metriport-internal#1634

build: update CW's patients.ts to use out instead of Util.out

f5368ef

Ref. metriport/metriport-internal#1634 Signed-off-by: Rafael Leite <[email protected]>

build: fix merge of CW's patient.get (call to validateCWEnabled)

2d16f1e

Ref. metriport/metriport-internal#1634 Signed-off-by: Rafael Leite <[email protected]>

leite08 force-pushed the 1634-improve-e2e-tests branch from a76c377 to 2d16f1e Compare May 27, 2024 20:02

leite08 mentioned this pull request May 28, 2024

RELEASE 1634 #2163

Merged

8 tasks

leite08 added this pull request to the merge queue May 28, 2024

Merged via the queue into develop with commit 7c2e953 May 28, 2024
36 checks passed

leite08 deleted the 1634-improve-e2e-tests branch May 28, 2024 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1634 E2E tests #2053

1634 E2E tests #2053

leite08 commented May 9, 2024 •

edited

leite08 May 18, 2024

leite08 May 18, 2024

leite08 May 18, 2024 •

edited

leite08 May 18, 2024

leite08 May 18, 2024

leite08 May 18, 2024

Orta21 May 23, 2024

leite08 May 24, 2024

Orta21 May 23, 2024

leite08 May 24, 2024

		dotenv.config({ path: path.resolve(...paths, ".env") });
		dotenv.config({ path: path.resolve(...paths, ".env.test") });

1634 E2E tests #2053

1634 E2E tests #2053

Conversation

leite08 commented May 9, 2024 • edited

Dependencies

Description

Testing

Release Plan

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leite08 May 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leite08 commented May 9, 2024 •

edited

leite08 May 18, 2024 •

edited