Add support for nodeSelector in qryn-deployment.yaml #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
qryn-deployment.yamldoes not do anything with thenodeSelectorvalue. Therefore, it is not possible to specify what kind of node qryn should be installed on. For example, in the case of a hybrid Linux+Windows cluster, it is possible that the qryn pod is deployed on a Windows node which are not supported at the time of writing.In addition to the change in
qryn-deployment.yaml, I have also added an example of a common use-case for thenodeSelectorvalue invalues.yaml