Add a few tests for time granularity parameters

[bshepherdson]

The API/model schemas for dashboard parameters are general enough
that they just work for this new type, which doesn't look very different
from a value parameter right now.

Part of #42118.

[bshepherdson]

• Add a few tests for time granularity parameters #42119 👈
• [QP] Support :temporal-unit parameters on MBQL queries #42116
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bshepherdson and the rest of your teammates on Graphite

[adam-james-v]

This looks good to me, approved, but if you've got a chance, consider:

I think if the temporal parameter should also be usable in a Question context, it's maybe a good idea to add a temporal unit parameter to the card api test too.

For example, maybe you could add a temporal unit parameter to this test (or make a new, small test):

https://github.com/metabase/metabase/blob/master/test/metabase/api/card_test.clj#L174-L185

[bshepherdson]

I think if the temporal parameter should also be usable in a Question context, it's maybe a good idea to add a temporal unit parameter to the card api test too.

Temporal parameters only apply to MBQL queries for now. Date truncation and extraction are "spelled" very differently in different databases (eg. DATE_TRUNC('month', some.column) vs. month(some.column) etc.), so it's nontrivial to figure out how the placeholders should work for this.

We want to do it eventually, but it's a stub future milestone and not planned currently.

[github-actions]

@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?