[QP] Support :temporal-unit parameters on MBQL queries
#42116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bshepherdson and the rest of your teammates on |
|
This is a new parameter `:type` (and `:widget-type`) to choose a time granularity (a `:temporal-unit`, eg. `month`, `day`, `day-of-week`) which should replace the unit on the target field for the parameter. The target field should be a breakout with a temporal type (date, datetime) that's compatible with the input unit. The value of the parameter should be a string or keyword naming one of the units: `"month"`, `:month`.
bshepherdson
force-pushed
the
qp-parameterize-time-granularity
branch
from
c4416d5
to
ba9f1ca
Compare
metamben
approved these changes
May 2, 2024
| (let [new-unit (keyword value)] | ||
| (lib.util.match/replace-in | ||
| query [:query :breakout] | ||
| [:field (_ :guard #(= target-field-id %)) (opts :guard #(= temporal-unit (:temporal-unit %)))] |
There was a problem hiding this comment.
Is it essential to check for the expected temporal-unit?
There was a problem hiding this comment.
Currently, not really. Soon we plan to allow multiple breakouts for the same column with different units, and this would become a latent bug.
There was a problem hiding this comment.
Would it be a better world where parameters were attached to specific occurrences of a column (via uuid)?
|
@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new parameter
:type(and:widget-type) to choose a timegranularity (a
:temporal-unit, eg.month,day,day-of-week)which should replace the unit on the target field for the parameter.
The target field should be a breakout with a temporal type (date,
datetime) that's compatible with the input unit. The value of the
parameter should be a string or keyword naming one of the units:
"month",:month.