Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Neo4j V5 #320

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Test Neo4j V5 #320

wants to merge 6 commits into from

Conversation

antejavor
Copy link

Description

Please briefly explain the changes you made here.

Pull request type

Please delete options that are not relevant.

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring with functional or API changes
  • Refactoring without functional or API changes
  • Build or packaging related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete section if this PR doesn't resolve any issues.

Closes (link to issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@antejavor antejavor changed the title Test > v4 Test Neo4j V5 Dec 6, 2024
@antejavor antejavor marked this pull request as ready for review December 6, 2024 11:06
@@ -39,7 +39,7 @@ pydantic = "^2.3.0"
psutil = "^5.9.0"
dacite = "^1.6.0"
adlfs = "^2023.9.0"
neo4j = "^4.4.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pushes users to use neo4j v5. Are we ok with this? that means no more v4

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@as51340 intent was to test if this works on a version bigger than v4 and use v5; we are not going to push users to use that version. PR auto-added you for a review since I need to set it to read because of the CI/CD test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants