-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Neo4j V5 #320
base: main
Are you sure you want to change the base?
Test Neo4j V5 #320
Conversation
@@ -39,7 +39,7 @@ pydantic = "^2.3.0" | |||
psutil = "^5.9.0" | |||
dacite = "^1.6.0" | |||
adlfs = "^2023.9.0" | |||
neo4j = "^4.4.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pushes users to use neo4j v5. Are we ok with this? that means no more v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@as51340 intent was to test if this works on a version bigger than v4 and use v5; we are not going to push users to use that version. PR auto-added you for a review since I need to set it to read because of the CI/CD test.
Description
Please briefly explain the changes you made here.
Pull request type
Please delete options that are not relevant.
Related issues
Delete section if this PR doesn't resolve any issues.
Closes (link to issue)
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################