Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update neo4j's client and flaky dependencies #299

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Jan 5, 2024

Description

Derisk potential update of Neo4j's client by adding support only for current major version.
Also, no need to pin exact version for pytest-flake8.

Pull request type

Please delete options that are not relevant.

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring with functional or API changes
  • Refactoring without functional or API changes
  • Build or packaging related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete section if this PR doesn't resolve any issues.

Closes (link to issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@as51340 as51340 marked this pull request as ready for review January 5, 2024 12:22
@as51340 as51340 self-assigned this Jan 5, 2024
@as51340 as51340 force-pushed the improve-gqla-versioning branch from e2a1c5c to 6b0cf03 Compare January 5, 2024 12:39
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good with this PR too

@antepusic antepusic merged commit c901486 into main Jan 5, 2024
7 checks passed
@antepusic antepusic deleted the improve-gqla-versioning branch January 5, 2024 13:19
@katarinasupe katarinasupe added this to the v1.5.1 milestone Jan 8, 2024
@gbotev1
Copy link

gbotev1 commented Dec 5, 2024

@as51340, I'm new to GQLAlchemy, and I saw that this PR appears to be the one that officially stopped supporting Neo4j V5. Given that it's almost a year later, I was hoping you (or someone else from this PR: @katarinasupe or @antepusic) could help provide some clarification on:

  1. Why only V4 is officially supported? Is that still the case today?
  2. I'm curious to learn more about what the potential negative impacts of upgrading to V5 locally would be?

@antejavor
Copy link

antejavor commented Dec 6, 2024

Hi @gbotev1, thanks for asking the question, it is more of an effort reason than a technical blocker.

We didn't go and test the GQL on v5, so it is currently sitting on v4, it may work on v5 by default, you can take a look into the following PR to see if everything works on version v5, will let you know when I reach some conclusion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants