Update neo4j dependency #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-linx
requested review from
Josipmrden,
katarinasupe,
as51340 and
antepusic
as code owners
katarinasupe
approved these changes
Aug 28, 2023
antepusic
approved these changes
Aug 28, 2023
|
Hi @alex-linx thank you for the contribution! The team will probably sync next week to agree on the next release. I will keep you updated. |
|
Please just remove trigger typing fix from here, so we have it at #260 :) |
alex-linx
force-pushed
the
update-dependency
branch
from
c5ca6b8 to
00d97ce
Compare
|
@katarinasupe Done |
|
Thank you @alex-linx for the contributions. We will work on the release at the end of the next week. Stay tuned :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the neo4j dependency to be more general, specifically to allow for using in conjuction with neo4j driver v5.
Pull request type
Related issues
Closes #262
Checklist:
I tested it against a neo4j running in docker.
Running against neo4j v5.1 did break because the uniqueness keyword doesn't exist anymore in show indexes.
However the neo4j driver v5 is backward compatbile so when running the tests against neo4j docker v4.4 they pass
######################################
Reviewer checklist (the reviewer checks this part)
######################################