Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing #260

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix typing #260

merged 1 commit into from
Sep 20, 2023

Conversation

alex-linx
Copy link
Contributor

Description

Fix typing for get_triggers method.

Pull request type

  • [ X] Code style update (formatting, renaming)

Checklist:

  • [ X] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my own code
  • [ X] I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [ X] New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on memgraph/docs

######################################

antepusic
antepusic approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@antepusic antepusic added the status: ready PR is ready for review label Aug 9, 2023
@katarinasupe
Copy link
Contributor

Hi @alex-linx, I see you included this fix in #263 too. Can you remove that change from there and leave it here?

@katarinasupe katarinasupe mentioned this pull request Aug 30, 2023
Merged
11 tasks
@antepusic antepusic added this to the v1.5.0 milestone Sep 11, 2023
@katarinasupe katarinasupe added status: ship it PR approved and removed status: ready PR is ready for review labels Sep 15, 2023
@katarinasupe katarinasupe merged commit 4963b4b into memgraph:main Sep 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarinasupe katarinasupe katarinasupe approved these changes

@antepusic antepusic antepusic approved these changes

@Josipmrden Josipmrden Awaiting requested review from Josipmrden Josipmrden is a code owner

@as51340 as51340 Awaiting requested review from as51340 as51340 is a code owner

Assignees
No one assigned
Labels
status: ship it PR approved
Projects
gqlalchemy
Status: Done
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-linx @katarinasupe @antepusic