Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark mods as client/server only #22

Open
maradotwebp opened this issue Jun 12, 2021 · 5 comments
Open

Mark mods as client/server only #22

maradotwebp opened this issue Jun 12, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@maradotwebp
Copy link
Owner

Mark some mods as client/server only when installing.
Requires a nice server exporter first, of course.

@maradotwebp maradotwebp added the enhancement New feature or request label Jun 12, 2021
@rlnt
Copy link

rlnt commented Jun 13, 2021

This could be used for automatically creating serverpacks for a pack version.
It would simply skip all the client mods automatically.

@Badtz13
Copy link
Contributor

Badtz13 commented Jul 7, 2021

I briefly looked into implementing this, but couldn't find a way to tell if mods were client or server only. I suppose it could be implemented as pax add --client <modname> but that seems a bit annoying. Is there somewhere I can find this data?

@maradotwebp
Copy link
Owner Author

Afaik theres no way to tell if a mod is client- or server-side just from the API, the user would have to enter that information themselves, probably something like ./pax mark appleskin --client-only which would set an installed mod as client- or serverside and save that information somewhere for later use.

Nevertheless I think we'll first need an exporter that doesn't export manifest.jsons, but direct .jar files. (#27)

@hipsterjazzbo
Copy link

This may be naive as I'm relatively new to modpack dev, but would something like this work:

zipgrep "net.minecraft.client" MODFILE.jar

If no results are returned, it's a server-only mod?

@Dreaming-Codes
Copy link

This may be naive as I'm relatively new to modpack dev, but would something like this work:

zipgrep "net.minecraft.client" MODFILE.jar

If no results are returned, it's a server-only mod?

Nope, or at least maybe but that's not what you need to detect... You need to detect whether is a client-only mod for making a server pack since server-only are also required for the internal server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants