-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds auto dependency installation and removal #38
Conversation
Co-authored-by: PanDoes <[email protected]>
Co-authored-by: PanDoes <[email protected]>
Co-authored-by: PanDoes <[email protected]>
…flag Co-authored-by: PanDoes <[email protected]>
Nice! Contributions aren't unwanted at all :D I simply haven't gotten around to contributions guidelines yet. |
…sages Co-authored-by: Badtz13 <[email protected]>
…alling. Otherwise it installs dependencies. Co-authored-by: Badtz13 <[email protected]>
Co-authored-by: Badtz13 <[email protected]>
Co-authored-by: PanDoes <[email protected]>
…anifestFiles, check if mods can be removed due to dependencies/dependents Co-authored-by: PanDoes <[email protected]>
Co-authored-by: PanDoes <[email protected]>
Summary of changes: Additionally we now recursively add and remove mod dependencies. For instance, adding A note on how we wrote to the manifest. Something to be considered: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few changes, but I think that should do the job. :D
Hope I didn't forget any edge cases with removing mods..
Makes sense, but I'd still advocate for at least putting them into a
Two possibilities:
|
Co-authored-by: Badtz13 <[email protected]>
Co-authored-by: Badtz13 <[email protected]>
…rguments with initManifestFile Co-authored-by: Badtz13 <[email protected]>
Co-authored-by: PanDoes <[email protected]>
Co-authored-by: Fröhlich A. <[email protected]>
Co-authored-by: PanDoes <[email protected]>
…ManifestMetadata object Co-authored-by: PanDoes <[email protected]>
Co-authored-by: PanDoes <[email protected]>
Co-authored-by: PanDoes <[email protected]>
We implemented all the changes you requested, including moving the metadata to a We have yet to implement a clean export method ( |
Yeah, clean export is for a story for another Pull Request. |
Last change - Otherwise, this looks good to me! Again, thanks for contributing - I didn't think I'd get much pull requests with a language like Nim :P |
Haha, didn't think I'd learn nim. It's a pretty nice language, as someone who likes C but has a hard time with python. Really enjoying pax, thanks for creating it. |
Co-authored-by: Fröhlich A. <[email protected]>
This pull request closes #8, which referenced a
--dependencies
flag to remove dependencies. However, we found that it was a better experience to simply ask the user if they wanted to remove dependencies if they exist. Feel free to revert the most recent commit if you think otherwise.You don't have any contribution guidelines, but this is a cool project and we wanted to help out. Sorry if this is unwanted.