-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qml: Change swipe dismiss gesture to animate opacity instead of position #211
base: master
Are you sure you want to change the base?
Conversation
VID_20240313_162116.mp4 |
As kwin disables the animation in maliit, I wonder if #181 may fix the issue you're seeing under Plasma? It's a smaller change, and it's unclear to me how animating opacity helps here. I still would prefer to just remove the swipe to close anyway, as there are so many problems with it, and the code is a bit complex. |
That PR doesn't seem to change anything, it still glitches in the same way when I swipe down |
I tested this now. In overall it seems like a huge improvement, but I found some nitpicks and one seemingly bigger issue: The bigger issue: When I put my finger on a letter key, then drag down until the keyboard disappears but keeping my finger pressed on the bezel, and then move my finger back into the screen area and just wildly around and in/out of the screen, often the keyboard will eventually get stuck in hidden mode. At this point it seems impossible to get it to show again, unless I tap "Input Method" in the tray enough to deactivate and reactivate the on-screen keyboard entirely. This means users without that tray icon will probably be stuck. Update: I tried to repeat this one 👆 and catch it on video, but sadly I failed. I'm not sure why. 😕 The smaller nitpicks:
(I tested this on a Steam Deck with postmarketOS Edge, if somehow relevant.) |
See rationale on #157, but TLDR we encounter a lot of issues with animating the position of the keyboard.
Here we instead change to animate the opacity, which allows the keyboard retain its dimensions during the animation.