Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml: Remove the swipe-to-close feature of the keyboard #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dobey
Copy link
Contributor

@dobey dobey commented Aug 9, 2022

There have been numerous problems with this interaction over the years,
and the implementation to make swipe to close work is a bit spread around.
One consistent issue has been the keyboard getting stuck partly closed, and
swiping upward does nothing, while in some cases swiping upward could also
cause the keyboard to be moved partially off the screen. This implementation
would also be in conflict of possible implementation of skeyer swipe support
in the future. So just remove it for now.

Copy link
Contributor

@espidev espidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry if this would have an impact on Lomiri, in Plasma Mobile we have a keyboard close button, is that something that exists there?

qml/Keyboard.qml Outdated Show resolved Hide resolved
There have been numerous problems with this interaction over the years,
and the implementation to make swipe to close work is a bit spread around.
One consistent issue has been the keyboard getting stuck partly closed, and
swiping upward does nothing, while in some cases swiping upward could also
cause the keyboard to be moved partially off the screen. This implementation
would also be in conflict of possible implementation of skeyer swipe support
in the future. So just remove it for now.
@dobey dobey force-pushed the drop-swipe-close branch from 2a0babe to 89c514b Compare March 14, 2024 02:53
@dobey
Copy link
Contributor Author

dobey commented Mar 14, 2024

I worry if this would have an impact on Lomiri, in Plasma Mobile we have a keyboard close button, is that something that exists there?

Ubuntu Touch still uses lomiri-keyboard, so this doesn't effect that. One can also just tap literally anywhere else in an app, and the keyboard should close, once whatever focused input field loses focus.

@espidev
Copy link
Contributor

espidev commented Mar 14, 2024

Any thoughts on perhaps replacing the logic with: #211 instead? I think it works well in avoiding the need to resize the keyboard window while still retaining the gesture, which can resolve the initial issue with half-finished gestures and the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants