-
Notifications
You must be signed in to change notification settings - Fork 152
July, 25, 2018
Olga Kopylova edited this page Aug 8, 2018
·
1 revision
Topics:
-
Allowed HTTP methods for Actions (15min, Oleksandr Gorkun)
- Anton Kril - use a marker interface instead:
- Method type is a static property of the action, so it can be declared statically (e.g., a marker interface, annotations)
- Gorkun: the list of method interfaces should be extensible
- Method type is a static property of the action, so it can be declared statically (e.g., a marker interface, annotations)
- Kublytskyi: use convention, location-based
-
getAllowedHttpMethods(): Gorkun - ✅(selected option) Marker interface: Kril, Melnykov, Kopylova
- ✅ use 404 status code, don't use 405 because GET should not be disabled (https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405)
- Anton Kril - use a marker interface instead:
- GraphQL schema for checkout (10min, Alex Paliarush)
- Kril: APIs should be idempotent
- Kril: APIs should support add items in bulk (Kotov: there are a few scenarios indeed), with single event for the action
- Kaplya: bulk operation will require to accept a list of different product types (which would require all of them implement one interface, which violates GraphQL rules)
- Alex: to create PR with the document for initial review