-
Notifications
You must be signed in to change notification settings - Fork 152
August, 22, 2018
Olga Kopylova edited this page Aug 22, 2018
·
10 revisions
- Extensions versioning (🕥20min, Roman Goncharuk) - cont'd from the last meeting
- Ravi: from Marketplace, the only requirement is to follow SemVer
- Navarr: it's easier to maintain one code base
- ✅ Olga: go with #1, Magento may provide possible solutions for extension developers to support different Magento versions, but in some cases it may be impossible. Magento does not guarantee that such solution will always exist.
- How to eliminate
protected
from Magento w/o breaking extensions? (🕥10min, Olga Kopylova, Michael Slabko)- Ravi: need to analyze
- Alex: it's risky to update everything. Make sure all public API is marked with
@api
and extension devs aware of what they should rely on - Igor: in some cases it's impossible to replace
protected
. Add test to EQP that validates that the extension doesn't use protected members - 🔔Ravi to discuss this internally - ✅ Olga: stop prohibiting removal of
protected
in private API. Should be validated on Marketplace extensions. In some cases, removal ofprotected
in public API should be analyzed and allowed too
- DevDocs embedded to code repos (🕥20min, Jeff Matthews)
- ✅Keep docs in the code base (git repo) and devdocs website will pull docs from the code base
- Docs should be reviewed during the sprint, so the docs are reviewed before code merging to mainline
- Plain markdown vs Jekyll?
- Olga: prefer the proposed solution (move docs to the codebase) with plain Markdown
- How to handle changes in between releases? - Igor: publish from release branches, those can go ahead of the release tags
- Ravi: make sure
docs
folder is excluded from packaging - Igor: may be less convenient for contributors due to multiple repos providing docs
- Igor: need guidelines on modularity of documentation
- Jeff: 🔔follow-up on this after investigating what's possible to implement
- Upgrade hook to look ahead for upgrade scripts in future versions (🕥10min, Peter Dohogne, Olga Kopylova)
If time permits:
-
https://github.com/magento/magento2/pull/12652 (🕥10min, Olga Kopylova)
- ✅Add to guidelines that it's better to throw an exception in such cases (🔔Max Lesechko)