Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal server error new fallback error type #1092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make internal server error new fallback error type #1092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/controller/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,15 @@ impl IntoResponse for Error {
StatusCode::BAD_REQUEST,
ErrorDetail::with_reason("Bad Request"),
)
}
_ => (
},
Self::BadRequest => (
StatusCode::BAD_REQUEST,
ErrorDetail::with_reason("Bad Request"),
),
_ => (
StatusCode::INTERNAL_SERVER_ERROR,
ErrorDetail::new("internal_server_error", "Internal Server Error"),
),
Comment on lines +227 to +230
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have an InternalServer enum in this match. Replace the INTERNAL_SERVER_ERROR variant with InternalServerError.

};

(public_facing_error.0, Json(public_facing_error.1)).into_response()
Expand Down
Loading