Make internal server error new fallback error type #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaplanelad
reviewed
Dec 25, 2024
Comment on lines
+227
to
+230
| _ => ( | ||
| StatusCode::INTERNAL_SERVER_ERROR, | ||
| ErrorDetail::new("internal_server_error", "Internal Server Error"), | ||
| ), |
There was a problem hiding this comment.
We already have an InternalServer enum in this match. Replace the INTERNAL_SERVER_ERROR variant with InternalServerError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all errors become a 400 Bad Request, unless an explicit error type is set. This is not ideal, as a bad request should not be retried by a client since it's the client that is at fault (as is for al 4xx codes). A better generic 'fallback' error would be a 500 internal server error, as it indicates something went wrong, and sending another attempt might very well succeed.
This pull requests changes the currenty behaviour by returning a 500 on all non-explicit errors.