feat: add address normalization #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Doesn't seem to work?
I'm still doing it wrong. I want to use "simp at *, instead of doing simp [*]"
…quivalent to baseline
shigoel
added a commit
that referenced
this pull request
Sep 26, 2024
### Description: We noticed that `simp_mem` required way too many heartbeats, so we change it to be less agressive. In future, based off of work in #184, we shall introduce a different tactic call `mem_omega` to close `omega` style goals, and making `simp_mem` (i.e., the internal rewriter within the symbolic simulation) to only perform rewriting, not goal-closing. ### Testing: What tests have been run? Did `make all` succeed for your changes? Was conformance testing successful on an Aarch64 machine? Conformance succeeds. ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Shilpi Goel <[email protected]>
|
Closing at @bollu 's request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts implementing address normalization in order to normalize bitvector expressions.
We aim for these to be upstreamed into the Lean bitvector proof development.
Testing:
make allsucceeds, nothing was change with regards to conformance.License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.