Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix drop cursor styling issue (#11336) #11345

Merged
merged 9 commits into from
Nov 10, 2024
Merged

Desktop: Fix drop cursor styling issue (#11336) #11345

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
670e3d0
Aligned drop cursor behavior with dark and light themes.
LEVIII007 Nov 8, 2024
e679a3a
Merge branch 'dev' into darkmode_dropcursor_visibility
LEVIII007 Nov 8, 2024
91b4395
Merge branch 'dev' into darkmode_dropcursor_visibility
LEVIII007 Nov 8, 2024
e2dba9a
retrigger checks
LEVIII007 Nov 9, 2024
bfa9907
Merge branch 'dev' into darkmode_dropcursor_visibility
LEVIII007 Nov 9, 2024
23aa2db
Merge branch 'dev' into darkmode_dropcursor_visibility
LEVIII007 Nov 9, 2024
f745393
Merge branch 'dev' into darkmode_dropcursor_visibility
LEVIII007 Nov 9, 2024
fb323db
Merge branch 'dev' into darkmode_dropcursor_visibility
LEVIII007 Nov 9, 2024
0c014ca
Merge branch 'dev' into darkmode_dropcursor_visibility
laurent22 Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/editor/CodeMirror/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ const createTheme = (theme: EditorTheme): Extension[] => {
// need to be overridden.
'&, &.CodeMirror': baseGlobalStyle,

'& .cm-dropCursor': {
backgroundColor: isDarkTheme ? 'white' : 'black',
width: '1px',
},

// These must be !important or more specific than CodeMirror's built-ins
'& .cm-content': {
fontFamily: theme.fontFamily,
Expand Down
Loading