Desktop: Fix drop cursor styling issue (#11336) #11345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@laurent22 It seems the action is unable to update the readme/cla_signatures.json file due to required status checks. All contributors, including myself, have signed the CLA as indicated in the comments, but this error is still blocking the checks. Could you please take a look or advise on how to resolve this? Thank you for your time and help! |
|
recheck |
|
Looks good, thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the drop cursor styling issue in the desktop editor. Previously, the drop cursor's color was inconsistent and difficult to configure. This change ensures the drop cursor's color is directly customizable and aligns with the app's theme settings.
Fixes #11336
Note
This pull request targets release-3.1.23
Demo after change :
Screenshot showing the drop cursor in white colour while dragging a file in dark mode:
joplin.mp4