Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove TODO for passing state #946

Draft
wants to merge 79 commits into
base: master
Choose a base branch
from

Conversation

beatrycze-volk
Copy link
Collaborator

@beatrycze-volk beatrycze-volk commented Apr 12, 2023

It looks like the page and simultaneousPages can be undefined, so better to avoid overwrite data with undefined.

Eventually @dikastes could tell us more in this topic.

Depends on #878

data-namespace-typo3-fluid="true"
lang="en">

<script>{docConfiguration -> f:format.raw()}</script>

Check notice

Code scanning / CodeQL

Syntax error Note

Error: Unexpected token
window.addEventListener('tx-dlf-documentLoaded', (e) => {
// TODO(client-side): When there are multiple instances of metadata plugin?
const container = document.querySelector('.dlf-metadata-container');
const rootline = {settings.rootline};

Check notice

Code scanning / CodeQL

Syntax error Note

Error: Unexpected token
// NOTE: The navigation plugin may be instantiated multiple times, even on a single page view
window.addEventListener('tx-dlf-documentLoaded', e => {
const controller = e.detail.docController;
const features = {features -> f:format.json() -> f:format.raw()};

Check notice

Code scanning / CodeQL

Syntax error Note

Error: Unexpected token
@sebastian-meyer sebastian-meyer added ⚙ feature A new feature or enhancement. and removed 🛠 maintenance A task to keep the code up-to-date and manageable. labels Oct 25, 2023
@sebastian-meyer sebastian-meyer marked this pull request as draft July 29, 2024 14:06
Kajetan Dvoracek and others added 29 commits August 2, 2024 11:32
On large documents, rendering metadata of all sections can take a
considerable amount of time.

Instead, allow to just render the current metadata, and fetch the
additional metadata in an API call.
- remove dead variables
- fix check for mime type
- removed unused e param from onStateChanged
- make fetchMetadata async so no spinner is needed
- remove unused paramaters
- decrease complexity of updateNavigationControls
Error:  `Inventory link with key "t3tsref:data-type-page-id" (data-type-page-id) not found.`
…rollers

Logically the document should not be displayed if its controller is not loaded
It looks like the page and simultaneousPages can be undefined, so better to avoid overwrite data with undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants