[FEATURE] Remove TODO for passing state #946
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-meyer
added
the
🛠 maintenance
sebastian-meyer
modified the milestones:
Kitodo.Presentation 4.1.0,
Kitodo.Presentation 5.0.0
beatrycze-volk
force-pushed
the
todo-change-state
branch
from
3195fe5
to
00822c0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| data-namespace-typo3-fluid="true" | ||
| lang="en"> | ||
|
|
||
| <script>{docConfiguration -> f:format.raw()}</script> |
Check notice
Code scanning / CodeQL
Syntax error Note
| window.addEventListener('tx-dlf-documentLoaded', (e) => { | ||
| // TODO(client-side): When there are multiple instances of metadata plugin? | ||
| const container = document.querySelector('.dlf-metadata-container'); | ||
| const rootline = {settings.rootline}; |
Check notice
Code scanning / CodeQL
Syntax error Note
| // NOTE: The navigation plugin may be instantiated multiple times, even on a single page view | ||
| window.addEventListener('tx-dlf-documentLoaded', e => { | ||
| const controller = e.detail.docController; | ||
| const features = {features -> f:format.json() -> f:format.raw()}; |
Check notice
Code scanning / CodeQL
Syntax error Note
sebastian-meyer
added
⚙ feature
sebastian-meyer
modified the milestones:
Kitodo.Presentation 5.0.0,
Kitodo.Presentation 5.1.0
- Remove unused import - Replace tabs with spaces
This will allow the navigation plugin to access the document, e.g., to get the number of pages.
On large documents, rendering metadata of all sections can take a considerable amount of time. Instead, allow to just render the current metadata, and fetch the additional metadata in an API call.
- remove dead variables - fix check for mime type
- removed unused e param from onStateChanged - make fetchMetadata async so no spinner is needed
- remove unused paramaters - decrease complexity of updateNavigationControls
Error: `Inventory link with key "t3tsref:data-type-page-id" (data-type-page-id) not found.`
…rollers Logically the document should not be displayed if its controller is not loaded
It looks like the page and simultaneousPages can be undefined, so better to avoid overwrite data with undefined
beatrycze-volk
force-pushed
the
todo-change-state
branch
from
00822c0
to
5233709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the page and simultaneousPages can be undefined, so better to avoid overwrite data with undefined.
Eventually @dikastes could tell us more in this topic.
Depends on #878