[FEATURE] Client-side paging #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatrycze-volk
commented
Dec 7, 2022
|
|
||
| <script> | ||
| window.addEventListener('tx-dlf-documentLoaded', (e) => { | ||
| // TODO(client-side): When there are multiple instances of metadata plugin? |
There was a problem hiding this comment.
This part should be tested and checked if the metadata is correctly displayed.
beatrycze-volk
commented
Dec 7, 2022
| var cnt = Math.min(this.fulltexts.length, this.images.length); | ||
| dlfViewer.prototype.initLoadFulltexts = function (visiblePages) { | ||
| if (this.docController === null) { | ||
| // TODO(client-side): Make it work then docController === null |
There was a problem hiding this comment.
Probably it should be: Make it work when docController === null
sebastian-meyer
added
⏳ prototype
beatrycze-volk
force-pushed
the
sprint-rebased
branch
from
b1bd553
to
12f215c
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
from
12f215c
to
08c9b78
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| data-namespace-typo3-fluid="true" | ||
| lang="en"> | ||
|
|
||
| <script>{docConfiguration -> f:format.raw()}</script> |
Check notice
Code scanning / CodeQL
Syntax error Note
There was a problem hiding this comment.
It looks like a false positive
| window.addEventListener('tx-dlf-documentLoaded', (e) => { | ||
| // TODO(client-side): When there are multiple instances of metadata plugin? | ||
| const container = document.querySelector('.dlf-metadata-container'); | ||
| const rootline = {settings.rootline}; |
Check notice
Code scanning / CodeQL
Syntax error Note
There was a problem hiding this comment.
It looks like a false positive
| // NOTE: The navigation plugin may be instantiated multiple times, even on a single page view | ||
| window.addEventListener('tx-dlf-documentLoaded', e => { | ||
| const controller = e.detail.docController; | ||
| const features = {features -> f:format.json() -> f:format.raw()}; |
Check notice
Code scanning / CodeQL
Syntax error Note
There was a problem hiding this comment.
It looks like a false positive
beatrycze-volk
force-pushed
the
sprint-rebased
branch
4 times, most recently
from
7d9cbf1
to
4d07ae1
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
2 times, most recently
from
7507d50
to
14853a2
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
from
b274075
to
b5bf409
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
2 times, most recently
from
03957df
to
c794dec
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
from
c794dec
to
64c6835
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
3 times, most recently
from
bbadfff
to
0a03d63
Compare
beatrycze-volk
force-pushed
the
sprint-rebased
branch
2 times, most recently
from
bcce7c6
to
a135764
Compare
|
All warnings "..." is defined but never used. are false positives. Those classes are called from fluid templates. |
On large documents, rendering metadata of all sections can take a considerable amount of time. Instead, allow to just render the current metadata, and fetch the additional metadata in an API call.
- remove dead variables - fix check for mime type
- removed unused e param from onStateChanged - make fetchMetadata async so no spinner is needed
- remove unused paramaters - decrease complexity of updateNavigationControls
beatrycze-volk
force-pushed
the
sprint-rebased
branch
from
56fa57c
to
34b3f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are tested - paging works.
Known problems: