Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Use nested extension configuration #1150

Merged
merged 4 commits into from
May 29, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

Over the time the configuration has grown quite significantly so introduction of nested configuration increases the readability.

@beatrycze-volk beatrycze-volk force-pushed the config-labels branch 2 times, most recently from 991ee34 to 52b744d Compare January 29, 2024 14:13
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Jan 29, 2024
@beatrycze-volk beatrycze-volk force-pushed the config-labels branch 3 times, most recently from 2822a16 to a2c3cd1 Compare January 30, 2024 11:17
@beatrycze-volk
Copy link
Collaborator Author

beatrycze-volk commented Jan 30, 2024

I would assume that it is not the error here:

Tests/Functional/FunctionalTestCase.php#L127
The use of function getenv() is discouraged

@beatrycze-volk beatrycze-volk changed the title [MAINTENANCE] Use nested extend configuration [MAINTENANCE] Use nested extension configuration Jan 30, 2024
@beatrycze-volk
Copy link
Collaborator Author

Codacy warning about getevn() should be solved by #1206

ext_conf_template.txt Outdated Show resolved Hide resolved
@sebastian-meyer sebastian-meyer merged commit ef7e928 into kitodo:master May 29, 2024
7 checks passed
sebastian-meyer added a commit that referenced this pull request May 29, 2024
@beatrycze-volk beatrycze-volk deleted the config-labels branch May 29, 2024 09:04
fschoelzel added a commit to fschoelzel/kitodo-presentation that referenced this pull request Jun 7, 2024
fschoelzel added a commit to fschoelzel/kitodo-presentation that referenced this pull request Jun 7, 2024
@fschoelzel
Copy link
Contributor

Found missing nesting key for metadataFormats in Resources/Private/Language/locallang_labels.xlf
See pull Request: #1264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants