Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement document validation before document is saved to database #1149

Merged
merged 7 commits into from
May 29, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

Allow index documents only if their metadata contains document format and record identifier

This functionality can be extended for more mandatory fields without which document should be treated as incomplete and as such should not be inserted into database and SOLR Index.

@beatrycze-volk beatrycze-volk marked this pull request as draft January 26, 2024 16:20
@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Jan 26, 2024
@beatrycze-volk beatrycze-volk force-pushed the document-validation branch 6 times, most recently from f6d749b to 9fc0c72 Compare January 30, 2024 13:12
@beatrycze-volk beatrycze-volk marked this pull request as ready for review January 30, 2024 13:17
@beatrycze-volk beatrycze-volk force-pushed the document-validation branch 2 times, most recently from c938411 to ea94186 Compare May 21, 2024 16:51
@sebastian-meyer
Copy link
Member

Following #1150 the config option needs to be renamed from requiredMetadataFields to general.requiredMetadataFields. I already did it in ext_conf_template.txt and the localization files while updating from master, but it still has to be done in the code.

@sebastian-meyer sebastian-meyer merged commit 35c7a31 into kitodo:master May 29, 2024
7 checks passed
@beatrycze-volk beatrycze-volk deleted the document-validation branch May 29, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants