Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement document validation before document is saved to SOLR #1158

Merged
merged 3 commits into from
May 29, 2024

Conversation

beatrycze-volk
Copy link
Collaborator

There exists possibility that during save to database document contains 'record_id', but already during saving to SOLR it doesn't. It is necessary to validate fields in both places to avoid it.

Depends on #1149

@sebastian-meyer sebastian-meyer added the ⚙ feature A new feature or enhancement. label Feb 4, 2024
@beatrycze-volk beatrycze-volk force-pushed the document-validation-2 branch 4 times, most recently from 7d9977c to e0734d0 Compare May 28, 2024 12:45
@beatrycze-volk
Copy link
Collaborator Author

Documentation build failed:

In inline-node.html.twig line 2:
                                                                               
  An exception has been thrown during the rendering of a template ("Failed to  
   connect to docs.typo3.org port 80 after 2010 ms: Couldn't connect to serve  
  r for "http://docs.typo3.org/typo3cms/TyposcriptReference/objects.inv.json"  
  .").                                                                         
                                                                               

In ErrorChunk.php line 56:
                                                                               
  Failed to connect to docs.typo3.org port [80](https://github.com/kitodo/kitodo-presentation/actions/runs/9269551905/job/25500591891?pr=1158#step:3:81) after 2010 ms: Couldn't connect  
   to server for "http://docs.typo3.org/typo3cms/TyposcriptReference/objects.  
  inv.json".                                                                   
                                                                               

In CurlResponse.php line 315:
                                                                               
  Failed to connect to docs.typo3.org port 80 after 2010 ms: Couldn't connect  
   to server for "http://docs.typo3.org/typo3cms/TyposcriptReference/objects.  
  inv.json".

@beatrycze-volk beatrycze-volk force-pushed the document-validation-2 branch 2 times, most recently from 4e9176e to 400b96a Compare May 29, 2024 09:27
There exists possiblity that during save to database document contains 'record_id', but already during saving to SOLR it doesn't. It is necessary to validate fields in both places to avoid it.
Copy link
Member

@sebastian-meyer sebastian-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few Codacy issues...

Classes/Command/IndexCommand.php Outdated Show resolved Hide resolved
Classes/Command/IndexCommand.php Outdated Show resolved Hide resolved
@sebastian-meyer sebastian-meyer merged commit 86c0697 into kitodo:master May 29, 2024
7 checks passed
@beatrycze-volk beatrycze-volk deleted the document-validation-2 branch May 29, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ feature A new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants