Improve the agent management UX #1014
+99
−15
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. If all required fields aren't populated the save fails but i don't know which required fields I didn't fill. need to go through each tab to check that. Maybe good to add some something in the tab names to indicate that the fields in that tab need to be filled/fixed (e.g a |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| "use client"; | ||
|
|
||
| import * as React from "react"; | ||
| import * as TabsPrimitive from "@radix-ui/react-tabs"; | ||
|
|
||
| import { cn } from "@/lib/utils"; | ||
|
|
||
| const Tabs = TabsPrimitive.Root; | ||
|
|
||
| const TabsList = React.forwardRef< | ||
| React.ElementRef<typeof TabsPrimitive.List>, | ||
| React.ComponentPropsWithoutRef<typeof TabsPrimitive.List> | ||
| >(({ className, ...props }, ref) => ( | ||
| <TabsPrimitive.List | ||
| ref={ref} | ||
| className={cn( | ||
| "inline-flex h-10 items-center justify-center rounded-md bg-muted p-1 text-muted-foreground", | ||
| className, | ||
| )} | ||
| {...props} | ||
| /> | ||
| )); | ||
| TabsList.displayName = TabsPrimitive.List.displayName; | ||
|
|
||
| const TabsTrigger = React.forwardRef< | ||
| React.ElementRef<typeof TabsPrimitive.Trigger>, | ||
| React.ComponentPropsWithoutRef<typeof TabsPrimitive.Trigger> | ||
| >(({ className, ...props }, ref) => ( | ||
| <TabsPrimitive.Trigger | ||
| ref={ref} | ||
| className={cn( | ||
| "inline-flex items-center justify-center whitespace-nowrap rounded-sm px-3 py-1.5 text-sm font-medium ring-offset-background transition-all focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 data-[state=active]:bg-background data-[state=active]:text-foreground data-[state=active]:shadow-sm", | ||
| className, | ||
| )} | ||
| {...props} | ||
| /> | ||
| )); | ||
| TabsTrigger.displayName = TabsPrimitive.Trigger.displayName; | ||
|
|
||
| const TabsContent = React.forwardRef< | ||
| React.ElementRef<typeof TabsPrimitive.Content>, | ||
| React.ComponentPropsWithoutRef<typeof TabsPrimitive.Content> | ||
| >(({ className, ...props }, ref) => ( | ||
| <TabsPrimitive.Content | ||
| ref={ref} | ||
| className={cn( | ||
| "mt-2 ring-offset-background focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2", | ||
| className, | ||
| )} | ||
| {...props} | ||
| /> | ||
| )); | ||
| TabsContent.displayName = TabsPrimitive.Content.displayName; | ||
|
|
||
| export { Tabs, TabsList, TabsTrigger, TabsContent }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want to redirect not logged in users to sign-in before trying to edit a card. Right now I can fill all fields in an agent card but can't create it until logged in. This maybe annoying