Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the agent management UX #1014

Open
wants to merge 2 commits into
base: features/use-sidebar
Choose a base branch
from

Conversation

sabaimran
Copy link
Member

  • Add support for seeing all steps of the agent modification flow via tabs at the top of the modal
  • Separate knowledge base & tool selection into two separate parts

- Add knowledge base as a separate section, apart from tools
- This makes it easier to navigate the different components quickly
@sabaimran sabaimran requested a review from debanjum December 20, 2024 22:42
@sabaimran sabaimran added the upgrade New feature or request label Dec 20, 2024
Copy link
Member

@debanjum debanjum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tab changes look good as give better orientation of what all needs to be filled to create an agent instead of the previous Previous > Next with no breadcrumb like help

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all required fields aren't populated the save fails but i don't know which required fields I didn't fill. need to go through each tab to check that. Maybe good to add some something in the tab names to indicate that the fields in that tab need to be filled/fixed (e.g a * suffix so Customize => Customize *) or the tab becomes red

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to redirect not logged in users to sign-in before trying to edit a card. Right now I can fill all fields in an agent card but can't create it until logged in. This maybe annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants