Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC]Add the translation string. #1365

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andy840119
Copy link
Member

As this PR, it can see that it will create 5 class for the translations, and some of them are duplicated.

Not really sure will it be a good idea or the standard to collect the translations:

  • Merge some localization file in a single class, like GeneratorStrings.
  • Give them a namespace, like Localisation/Edit/Generator/NoteGeneratorStrings.cs?
  • Common string in the sub-folder? Like Localisation/Edit/EditCommonStrings.cs.

@andy840119 andy840119 added enhancement New feature or request localization Translation related. labels Jun 5, 2022
@andy840119
Copy link
Member Author

andy840119 commented Jun 5, 2022

Oops, seems placing the localization class into folder cannot be detected by the localization tool.

dotnet localisation to-resx ./osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj

@andy840119
Copy link
Member Author

andy840119 commented Jun 15, 2023

  • test todo list in the description.

@CloneWith
Copy link
Contributor

Is it possible to put all strings into one class, like Localisation.UIStrings?

Then all string translations can use the same method to be fetched, and duplicate strings would be naturally merged into one string.

@andy840119
Copy link
Member Author

Is it possible to put all strings into one class, like Localisation.UIStrings?

No, because will be hard to manage all the translation.

#1265 (comment)

Here's the rule about how to place the translation designed before, i guess will follow this rule after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request localization Translation related. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants