Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use handle_outgoing_message for ZMQ replies #1089

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Nov 23, 2022

Follow-up on #1047.

This was an oversight in that PR. We should use handle_outgoing_message to reply on the websocket.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (5646bf8) to head (0fa1fed).
Report is 279 commits behind head on main.

Files Patch % Lines
...ter_server/services/kernels/connection/channels.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   77.47%   77.85%   +0.37%     
==========================================
  Files          68       68              
  Lines        8299     8299              
  Branches     1649     1649              
==========================================
+ Hits         6430     6461      +31     
+ Misses       1450     1438      -12     
+ Partials      419      400      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073 blink1073 enabled auto-merge (squash) November 23, 2022 17:06
@blink1073 blink1073 merged commit 890b882 into jupyter-server:main Nov 23, 2022
@Zsailer Zsailer deleted the handle-outgoing-message branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants