Skip to content

Commit

Permalink
Use handle_outgoing_message for ZMQ replies (#1089)
Browse files Browse the repository at this point in the history
Co-authored-by: Steven Silvester <[email protected]>
  • Loading branch information
Zsailer and blink1073 authored Nov 23, 2022
1 parent 5646bf8 commit 890b882
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions jupyter_server/services/kernels/connection/channels.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def replay(value):
self.log.info("Replaying %s buffered messages", len(replay_buffer))
for channel, msg_list in replay_buffer:
stream = self.channels[channel]
self._on_zmq_reply(stream, msg_list)
self.handle_outgoing_message(stream, msg_list)

connected.add_done_callback(replay)
else:
Expand Down Expand Up @@ -379,7 +379,7 @@ def replay(value):

def subscribe(value):
for _, stream in self.channels.items():
stream.on_recv_stream(self._on_zmq_reply)
stream.on_recv_stream(self.handle_outgoing_message)

connected.add_done_callback(subscribe)
ZMQChannelsWebsocketConnection._open_sockets.add(self)
Expand Down

0 comments on commit 890b882

Please sign in to comment.