-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Consistent Database Name Validation #44623
Open
brianteeman
wants to merge
3
commits into
joomla:5.3-dev
Choose a base branch
from
brianteeman:db_name_validate
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
richard67
reviewed
Dec 15, 2024
administrator/components/com_config/src/Model/ApplicationModel.php
Outdated
Show resolved
Hide resolved
richard67
reviewed
Dec 15, 2024
administrator/components/com_config/src/Model/ApplicationModel.php
Outdated
Show resolved
Hide resolved
@richard67 appreciate the review but please leave it for me to approve/accept the changes |
I have tested this item ✅ successfully on aaa4f89
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623. |
I have tested this item ✅ successfully on aaa4f89 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24291 .
Summary of Changes
Since 23704 the db name validation in the installer is stricter than the config component
Testing Instructions
In the global config options try to change the database name to something with a forbidden character eg for mysql add a \
Actual result BEFORE applying this Pull Request
Database connection test failed with the following error: 1049: Unknown database 'test_joomla'
Expected result AFTER applying this Pull Request
The database name is invalid. It must not contain the following characters: \ /
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed