Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Consistent Database Name Validation #44623

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #24291 .

Summary of Changes

Since 23704 the db name validation in the installer is stricter than the config component

Testing Instructions

In the global config options try to change the database name to something with a forbidden character eg for mysql add a \

Actual result BEFORE applying this Pull Request

Database connection test failed with the following error: 1049: Unknown database 'test_joomla'

Expected result AFTER applying this Pull Request

The database name is invalid. It must not contain the following characters: \ /

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 15, 2024
@brianteeman
Copy link
Contributor Author

@richard67 appreciate the review but please leave it for me to approve/accept the changes

@fgsw
Copy link

fgsw commented Dec 16, 2024

I have tested this item ✅ successfully on aaa4f89

Result BEFORE applying this Pull Request Result AFTER applying this Pull Request
Screen Shot 2024-12-16 at 08 13 30 Screen Shot 2024-12-16 at 08 22 14

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

@ChristineWk
Copy link

I have tested this item ✅ successfully on aaa4f89


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

@alikon
Copy link
Contributor

alikon commented Dec 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants