Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Consistent validation of the database name #24291

Closed
wilsonge opened this issue Mar 21, 2019 · 4 comments
Closed

[4.0] Consistent validation of the database name #24291

wilsonge opened this issue Mar 21, 2019 · 4 comments

Comments

@wilsonge
Copy link
Contributor

com_config is looser at validating the database name than the installer (which was patched as part of #23704). This should be normalised using a standard validation filter for JForm

@wilsonge wilsonge changed the title Consistent validation of the database name [4.0] Consistent validation of the database name Mar 21, 2019
@ghost ghost added the J4 Issue label Apr 4, 2019
@joomdonation
Copy link
Contributor

From what I see, that kind of validation is nice to have but not needed anymore. The reason is because before the change is saved, we even try to connect to database to see if it works before saving the change.

With that said, I'm closing this issue for now. Please re-open it if you still want to have this validation rule implemented.

@wilsonge
Copy link
Contributor Author

I do want it because it's more about the security of what we are validating before trying to connect than whether it works or not

@alikon
Copy link
Contributor

alikon commented Feb 19, 2023

plesase test #39889

@richard67
Copy link
Member

Closing as having a pull request. Please test #44623 . Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants