Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] [RFC] CMSPlugin: Subscriber Registration Checker Interface #43657

Open
wants to merge 6 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 15, 2024

Summary of Changes

Adding Subscriber Registration Checker. Interface that allows Plugins to be checked before listener registration.
This allows the plugin to be registered only wheen special conditions are met, eg: only for specific application.

Testing Instructions

Code review by maintainers.

Edit

public function onBeforeCompileHead()
{
$app = $this->getApplication();

And add dd('Works'); at top of this method.

Then open Administrator page: you should get message "works"
And then open Site page: the page should be opened as usual

Link to documentations

Please select:

@Fedik Fedik added the Feature label Jun 15, 2024
@Fedik Fedik changed the title [5.2] CMSPlugin: Subscriber Registration Checker Interface [5.2][RFC] CMSPlugin: Subscriber Registration Checker Interface Jun 15, 2024
@joomla-cms-bot joomla-cms-bot added the RFC Request for Comment label Jun 15, 2024
@Fedik Fedik changed the title [5.2][RFC] CMSPlugin: Subscriber Registration Checker Interface [5.x][RFC] CMSPlugin: Subscriber Registration Checker Interface Jun 15, 2024
@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.x][RFC] CMSPlugin: Subscriber Registration Checker Interface [5.3] [RFC] CMSPlugin: Subscriber Registration Checker Interface Sep 2, 2024
 Conflicts:
	plugins/system/guidedtours/src/Extension/GuidedTours.php
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RFC Request for Comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants