-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] [RFC] CMSPlugin: Lazy subscriber interface and decorator #43658
Open
Fedik
wants to merge
16
commits into
joomla:5.3-dev
Choose a base branch
from
Fedik:plugin-lazy-subscriber
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08e5c6d.
Fedik
changed the title
[5.2][RFC] CMSPlugin: Lazy subscriber interface and decorator
[5.x][RFC] CMSPlugin: Lazy subscriber interface and decorator
Jun 15, 2024
This pull request has been automatically rebased to 5.3-dev. |
HLeithner
changed the title
[5.x][RFC] CMSPlugin: Lazy subscriber interface and decorator
[5.3] [RFC] CMSPlugin: Lazy subscriber interface and decorator
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adding LazySybscriber interface and decorator.
The decorator
LazyServiceSubscriber
allows to instantiate the plugin with heavy dependencies only when the event is actualy dispatched.The interface
LazySubscriberInterface
also allows to useLazyServiceEventListener
, hovewer the plugin should implement it on its own.Example usage of the decorator for the plugin with heavy dependencies:
Code for
plugins/system/example/services/provider.php
.Before:
After:
The decorator can work very nicely with (in future):
But I will update it depend what first will be merged this PR or that PR.
Testing Instructions
Code review by maintainers.
Check that following plugins works as before:
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
References: