Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bootstrap3 and Visual Enhancement #78

Closed
wants to merge 3 commits into from
Closed

Use Bootstrap3 and Visual Enhancement #78

wants to merge 3 commits into from

Conversation

asika32764
Copy link

  • Add Bootstrap3 Adapter to make old code with BS3 style.
  • Some visual update to fit Joomla blue style
  • Update css to make style look like Github

http://about.asika.tw/sms-joomla-coding-standards/

140925-0002

@asika32764 asika32764 mentioned this pull request Sep 24, 2014
@javigomez
Copy link
Contributor

Thanks @asika32764 👍

@Hutchy68 is also working on a proposal here: http://hutchy68.github.io/coding-std-new/ that is almost ready, let's see if he can incorporate some of your ideas

@asika32764
Copy link
Author

Thanks, the work of @Hutchy68 is also awesome. I'm focus on css and styles, did not change js and html too much, so I think it won't be hard to merges theses two works.

@asika32764
Copy link
Author

And is there any plan that what time to merge @Hutchy68's work?

It's seems the HTML will be change a lot. My team has already start translating zh-TW version and we add a language menu, it will change HTML and JS code. I wish we can avoid the conflict before it happend.

#54 (comment)

@Hutchy68
Copy link
Contributor

Hi @asika32764 part of the goal of the new coding standards was to get us off of MooTools. As a side effect, the new one is already using Bootstrap 3.2 with the new page generator.

Next was to look at localisation. Docpad can handle a multilanguage site. Everything is in how you structure the /documents directory and set up the configuration file, etc.

/src
  /documents
    /appendices
    /code
    /styleguides
   /es-ES
      /appendices
      /code
      /styleguides
   /fr-FR
      /appendices
      /code
      /styleguides
....
....
....
   /zh-TW
      /appendices
      /code
      /styleguides

So yes, a multilanguage version of the manual is planned. First, I need to work out the relative path issue, Hutchy68/coding-std-new#1. I'm not sure if it is gh-pages deployment plugin or a configuration setting in my .coffee file. Currently, I have to use an absolute path to make the css and js work correctly. The /out directory write works perfectly in development, but not in gh-pages.

As far as how soon? As quick as I can get the one issue resolved, I think we can move it over then start working on multilanguage and other improvements if needed.

@asika32764
Copy link
Author

Hi @Hutchy68

This is a good work, I think my team can just translate the zh-tw version and provide the md files. Let the multilanguage handler implement on your works.

If anything we can help, please let me know.

Thank you.

@mbabker
Copy link
Contributor

mbabker commented Jun 16, 2015

9 months of no activity. Any interest in following up or is this something we can close for lack of interest (along with my parent item #52)?

@photodude
Copy link
Contributor

@mbabker What is needed to get this PR merged?

@Hutchy68
Copy link
Contributor

Hutchy68 commented Apr 7, 2016

Me 😀

I've now built a few static sites with docpad and it's all in how you run the command line to build with appropriate switch variables. I can't get to it until the following weekend.

@photodude
Copy link
Contributor

Is this needed considering #141 ?

@mbabker
Copy link
Contributor

mbabker commented Jan 8, 2017

Nope. If I ever figure out what bug it was Brian was trying to get addressed blocking the completion of integrating everything into https://developer.joomla.org then everything will be hosted natively through that site.

@mbabker mbabker closed this Jan 8, 2017
wilsonge added a commit to wilsonge/coding-standards that referenced this pull request Oct 1, 2018
Prepared statement support for SQL Server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants