-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage 2 - remove gh-pages #141
Conversation
Just say when... |
Will do in a few hours
|
Hit a bug in the component with alias generation so it wont be today |
Ready for review - https://developer.joomla.org/coding-standards.html |
GitHub's pages have syntax highlighting integrated into its CSS. We'll need to add a CSS library for it to do the same. |
All we might need is https://github.com/joomla/jissues/blob/master/www/media/css/code.css which we use on the issue tracker for our markdown demo pages - https://issues.joomla.org/markdown (code tab) |
Actually, that CSS is based on an old version of GitHub's markdown parser, it isn't really good anymore. I did test out https://github.com/primer/github-syntax-light quickly and it does the job adequately. I can add loading that to our layout override later on. |
Page one
I'm assuming this section needs to be updated Other than the syntax highlighting, it looks fairly good. We also have a new PR to include covering SCSS See #146 |
About the section Contributing to this manual i have noted this in the other issue too. But atm this is only a 1v1 copy of the content :) |
I've added the CSS for the syntax highlighting. Content updates can be handled as pull requests to the master branch. |
This is stage 2 of the move from gh-pages.
Please dont merge until after step 1 has been merged AND until it has been added to dev.j.o