feat: update to js-yaml v4, reduce bundle size by ~70% #145
Conversation
sakulstra
changed the title
There was a problem hiding this comment.
@sakulstra thanks for the PR.
If you could make the suggested change that would be great. FWIW I was planning on switching to this yaml lib, since it's lighter, well tested, and the code is pretty solid. Since we're doing a major version bump anyway, would you mind trying out that lib instead? And if all tests pass, let's use that library. If not we stick with yaml-js for now until someone has a chance to look into it.
Either way, thanks for taking the time to submit this PR.
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "gray-matter", | |||
| "description": "Parse front-matter from a string or file. Fast, reliable and easy to use. Parses YAML front matter by default, but also has support for YAML, JSON, TOML or Coffee Front-Matter, with options to set custom delimiters. Used by metalsmith, assemble, verb and many other projects.", | |||
| "version": "4.0.3", | |||
| "version": "4.0.4", | |||
There was a problem hiding this comment.
Please revert this. version changes are typically done by maintainers. Also, I personally like to play it safe with major version bumps, especially since incompatible node versions can easily sneak in.
will do in another pr to not block this one |
|
@jonschlinkert any chance this could be merged? |
it's #137 + the adjusted missing files from the comment
@jonschlinkert would appreciate if you could have a look, the change seems trivial and tests are still passing