-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updating to use yaml #147
base: master
Are you sure you want to change the base?
Conversation
@jonschlinkert with #148 applied tests are passing. |
I'm not at all sure about that lol. Thank you for doing this and for bringing it to my attention. I was initially under the impression that edit: and also, thank you for taking the time to do this, and apologies for making you jump through hoops. I promise we'll get this merged and published as soon as we settle on which library to use. |
Would in fact go with |
@jonschlinkert any chance of getting this merged? 😅 |
@jonschlinkert ping 😅 |
@jonschlinkert 😿 - quite a lot of ppl are using this library (1M downloads per week). Would be really good if this could be merged anytime soon. |
@jonschlinkert ping on this, let me know if anything prevents merging. |
It no longer is. It shows yaml at 102.6 kB and js-yaml at 39 kB. |
use yaml instead of js-yaml
as requested in #145
@jonschlinkert are you sure
yaml
is smaller thanjs-yaml
(for some reason bundlephobia is broken for yaml and vscode showing bigger package size, might be wrong due to shaking though)yaml
seems to behave slightly different as you can see in the two failing tests.