Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow minArgs 0 for valid-expect #1688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sonnyp
Copy link

@sonnyp sonnyp commented Dec 20, 2024

@sonnyp sonnyp force-pushed the valid-expect-minArgs-0 branch from 3a7fed7 to 53f6330 Compare December 20, 2024 19:56
@sonnyp sonnyp changed the title feat: Allow minArgs 0 for valid-expect feat: allow minArgs 0 for valid-expect Dec 20, 2024
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 20, 2024

thanks, I'm happy with this but will probably wait until after the holidays to land this to give the link checker a chance to come right (seems to be unhappy with https://eslint.org/docs/latest/use/core-concepts#rule-suggestions which looks bonked anyway, and is generated by eslint-doc-generator so I'm hopeful it'll get resolved upstream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants