feat: Allow minArgs 0 for valid-expect

This is particularly useful for jest-extended https://jest-extended.jestcommunity.dev/docs/matchers/pass https://jest-extended.jestcommunity.dev/docs/matchers/fail
jest-community · Dec 20, 2024 · 3a7fed7 · 3a7fed7
1 parent 5b59029
commit 3a7fed7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/docs/rules/valid-expect.md b/docs/rules/valid-expect.md
@@ -56,7 +56,7 @@ This rule is enabled by default.
     },
     minArgs: {
       type: 'number',
-      minimum: 1,
+      minimum: 0,
     },
     maxArgs: {
       type: 'number',

diff --git a/src/rules/__tests__/valid-expect.test.ts b/src/rules/__tests__/valid-expect.test.ts
@@ -129,6 +129,10 @@ ruleTester.run('valid-expect', rule, {
       code: 'test("valid-expect", async () => { expect(Promise.resolve(2)).toResolve(); });',
       options: [{ asyncMatchers: ['toResolveWith'] }],
     },
+    {
+      code: 'expect().pass();',
+      options: [{ minArgs: 0 }],
+    },
   ],
   invalid: [
     {

diff --git a/src/rules/valid-expect.ts b/src/rules/valid-expect.ts
@@ -176,7 +176,7 @@ export default createRule<[Options], MessageIds>({
           },
           minArgs: {
             type: 'number',
-            minimum: 1,
+            minimum: 0,
           },
           maxArgs: {
             type: 'number',