New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the column extractR with corrections #152

Open

saxenism wants to merge 2 commits into jcrodriguez1989:master from saxenism:col_ext

Contributor

saxenism commented Mar 28, 2020 •

edited

Loading

In response to the review of my PR here, I have opened this PR from an alternative branch of my forked repository(not the master).

All the mentioned failed test cases are now passing and thus have been added to the tests file.
Code Styling has been paid special attention to.
Mentioned changes were made to the vignette.
Iterators were not initialized.
Functions were made efficient and all return statements were removed.

Thanks!

Rahul Saxena added 2 commits

March 29, 2020 00:29


          Added the col extractR with corrections

bda91b4


          Made changes in vignette

653e6c0

saxenism mentioned this pull request

Added the column extraction optimiser #147

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet