Added the column extraction optimiser #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @hinduBale , you have made a lot of work here, so I have a lot of comments to do xD
- First of all, always create a branch before doing a Pull Request (PR). Here, you are doing a PR from your forked master branch.
- If we say that using .subset is better for data.frames, lists, etc, it would be great to prove it, as you did for the data.frame case.
- I would recommend you check out the styler R package, you are having several non-styled lines of code that would be automatically fixed by this package ;) .
|
To resolve all the conversations, especially the point where you mentioned that this work should be on a different forked branch and not the master, I've create a new PR [here] (#152) .Please have a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the specifications provided here, I've added the opt-column-extractor.R file as part of the hard test along with relevant tests and vignette.