Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Remove temporary SkipBinaryAttrs flag from e2e tests #5436

Merged
merged 1 commit into from May 11, 2024

Conversation

james-ryans
Copy link
Contributor

@james-ryans james-ryans commented May 10, 2024

Which problem is this PR solving?

Description of the changes

  • Delete the SkipBinaryAttrs flag from StorageIntegration.

How was this change tested?

  • Tested locally by running all the e2e storage tests. e.g. STORAGE=grpc SPAN_STORAGE_TYPE=memory make jaeger-v2-storage-integration-test

Checklist

@james-ryans james-ryans requested a review from a team as a code owner May 10, 2024 09:24
@james-ryans james-ryans requested a review from jkowall May 10, 2024 09:24
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (5ddcaa9) to head (d56a03c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5436   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         334      334           
  Lines       16233    16233           
=======================================
  Hits        15469    15469           
  Misses        583      583           
  Partials      181      181           
Flag Coverage Δ
badger_v1 7.97% <ø> (ø)
badger_v2 ?
cassandra-3.x-v1 16.27% <ø> (ø)
cassandra-3.x-v2 1.83% <ø> (+0.02%) ⬆️
cassandra-4.x-v1 16.27% <ø> (ø)
cassandra-4.x-v2 1.83% <ø> (+0.02%) ⬆️
elasticsearch-5.x 1.75% <ø> (+0.01%) ⬆️
elasticsearch-6.x 1.75% <ø> (+0.02%) ⬆️
elasticsearch-7.x 1.75% <ø> (+0.01%) ⬆️
elasticsearch-8.x 1.75% <ø> (+0.01%) ⬆️
grpc_v1 10.13% <ø> (ø)
grpc_v2 7.39% <ø> (+0.03%) ⬆️
kafka 9.68% <ø> (ø)
opensearch-1.x 1.76% <ø> (+0.03%) ⬆️
opensearch-2.x 1.75% <ø> (+0.02%) ⬆️
unittests 93.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 10, 2024
@yurishkuro yurishkuro changed the title [v2] Remove e2e test temporary SkipBinaryAttrs flag [v2] Remove temporary SkipBinaryAttrs flag from e2e tests May 10, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) May 10, 2024 14:06
@yurishkuro yurishkuro merged commit fb5c804 into jaegertracing:main May 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jaeger-v2]: Remove SkipBinaryAttrs flag from storage integration
2 participants