-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2]: Remove SkipBinaryAttrs flag from storage integration #5341
Labels
Comments
4 tasks
hey @james-ryans. @yurishkuro I would like to work on it |
4 tasks
Hi @prakrit55, actually we have an ongoing PR for this at #5436. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requirement
As a contributor, I want to remove the
SkipBinaryAttrs
flag from storage integration test that was temporarily added to bypass the issue sourced from upstream dependency. Marked with this comment #5322 (comment).Problem
The
SkipBinaryAttrs
flag was added to bypass upstream issue because OTELpkg/translator/jaeger
has a bug that converts Jaeger proto BINARY type tags into OTLP STRING type but remains in STRING type when converted back into Jaeger proto.Proposal
Remove
SkipBinaryAttrs
flag from storage integration test once the issue at open-telemetry/opentelemetry-collector-contrib#32208 has been resolved.Open questions
No response
The text was updated successfully, but these errors were encountered: