Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/JA-111 BrowseControllerTests #101

Merged
merged 15 commits into from
May 28, 2024
Merged

Feature/JA-111 BrowseControllerTests #101

merged 15 commits into from
May 28, 2024

Commits on May 18, 2024

  1. Clean up BrowseController 

    Remove old TODO comment, remove unused usings.
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    4e3ee65 View commit details
    Browse the repository at this point in the history

  2. Add BrowseControllerTests with setup and 1 test 

    Test: Ads_WhenProvidedInvalidPageNumber_ShouldAskForPageOne
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3f66221 View commit details
    Browse the repository at this point in the history

  3. Add test for pageNumber to BrowseControllerTests 

    Test: Ads_WhenProvidedValidPageNumber_ShouldAskForCorrectPage
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1294398 View commit details
    Browse the repository at this point in the history

  4. Add 2 tests to BrowseControllerTests for return type of Ads 

    Tests:
- Ads_WhenResponseIsUnsuccessful_ShouldReturnRedirectToAction
- Ads_WhenResponseIsSuccessful_ShouldReturnView
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3518e56 View commit details
    Browse the repository at this point in the history

  5. Rename AdDetailsRequest/Response to GetAdDetails...

    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    238000b View commit details
    Browse the repository at this point in the history

  6. Add test to BrowseControllerTests for AdDetails 

    Test - AdDetails_WhenUserIdIsNull_ShouldReturnRedirectToAction
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    7208e6d View commit details
    Browse the repository at this point in the history

  7. Add test to BrowseControllerTests for AdDetails 

    Test - AdDetails_WhenUserIsNotNull_ShouldSendCorrectRequest
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    601a02a View commit details
    Browse the repository at this point in the history

  8. Add 2 tests to BrowseControllerTests for AdDetails 

    Tests:
- AdDetails_WhenResponseIsNull_ShouldReturnRedirectToAction
- AdDetails_WhenResponseIsNull_ShouldReturnView
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c73a07b View commit details
    Browse the repository at this point in the history

  9. Change name of 1 test in BrowseControllerTests

    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    7658e95 View commit details
    Browse the repository at this point in the history

  10. Change name of UsersScheduleRequest/Response to GetUsersSchedule...

    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    705276f View commit details
    Browse the repository at this point in the history

  11. Add tests to BrowseControllerTests for Schedule action 

    Tests:
- Schedule_WhenUserIdIsNull_ShouldReturnRedirectToAction
- Schedule_WhenUserIdIsNotNull_ShouldReturnRedirectView
- Schedule_WhenUserIdIsNotNull_ShouldSendCorrectRequest
    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    fb3b249 View commit details
    Browse the repository at this point in the history

  12. Clean up code in BrowseControllerTests by extracting 2 helper methods

    @Zjyslav
    Zjyslav committed May 18, 2024
    Configuration menu
    Copy the full SHA
    a8bf88f View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Merge branch 'develop' into feature/ja-111-browse-controller-tests

    @Zjyslav
    Zjyslav committed May 26, 2024
    Configuration menu
    Copy the full SHA
    31add51 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Extract base class for BrowseControllerTests, split tests by action

    @Zjyslav
    Zjyslav committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d1cf84f View commit details
    Browse the repository at this point in the history

  2. Move 1 helper method from base to AdsTests 

    Since no other tests use this method, there's no need to keep it in base class.
    @Zjyslav
    Zjyslav committed May 27, 2024
    Configuration menu
    Copy the full SHA
    524dd34 View commit details
    Browse the repository at this point in the history