Feature/JA-111 BrowseControllerTests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old TODO comment, remove unused usings.
Test: Ads_WhenProvidedInvalidPageNumber_ShouldAskForPageOne
Test: Ads_WhenProvidedValidPageNumber_ShouldAskForCorrectPage
Tests: - Ads_WhenResponseIsUnsuccessful_ShouldReturnRedirectToAction - Ads_WhenResponseIsSuccessful_ShouldReturnView
Test - AdDetails_WhenUserIdIsNull_ShouldReturnRedirectToAction
Test - AdDetails_WhenUserIsNotNull_ShouldSendCorrectRequest
Tests: - AdDetails_WhenResponseIsNull_ShouldReturnRedirectToAction - AdDetails_WhenResponseIsNull_ShouldReturnView
Tests: - Schedule_WhenUserIdIsNull_ShouldReturnRedirectToAction - Schedule_WhenUserIdIsNotNull_ShouldReturnRedirectView - Schedule_WhenUserIdIsNotNull_ShouldSendCorrectRequest
Since no other tests use this method, there's no need to keep it in base class.
skrawus
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created tests for
BrowseController.I'm testing:
ViewResultorRedirectToActionResult?)There is some repetition in tests, but I wanted some cases to clearly stand out from others (valid values vs invalid).
I also changed names of some DTOs to be consistent with names of the methods they are used in.