-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds functionality for Trials mode file parsing #1878
Conversation
Resolved merge conflict... this is ready for review. |
Updated description with links to Universal Trials Mode PR: ikemen-engine/modules#3. It's still in draft as I resolve some of the outstanding issues, but a compiled executable from this PR can be used to test the trials mode module. |
Threw this back into draft. Adding some functionality as I do testing with more unique characters. Latest updates:
|
Added var-val pairs on a per-trial step basis to allow for checking var-val pairs during the trial step (separate from the trial display one var-val pairs). |
This PR is no longer required. Trials mode is now a completely standalone Lua module. |
This PR introduces localized changes to three files to support a universal Trials mode which will be delivered as a PR in the external modules repo (found here: ikemen-engine/modules#3). This parsing functionality is required to enable the most seamless Trials mode experience possible.
This PR modifies
char.go
to enable reading atrials.def
file specified in the char's *.def file. Parsing of the trials data is done by this function and offers future growth functionality. Since the Trials mode is written in Lua,script.go
is also modified to allow Lua functions to read the trials data parsed from thetrials.def
file. Finally,training.zss
has a one line change to enable training functionality in Trials mode.Details on the structure of
trials.def
files are included in the trials.lua PR (ikemen-engine/modules#3).