Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds functionality for Trials mode file parsing #1878

Closed
wants to merge 29 commits into from

Conversation

two4teezee
Copy link
Contributor

@two4teezee two4teezee commented Jul 6, 2024

This PR introduces localized changes to three files to support a universal Trials mode which will be delivered as a PR in the external modules repo (found here: ikemen-engine/modules#3). This parsing functionality is required to enable the most seamless Trials mode experience possible.

This PR modifies char.go to enable reading a trials.def file specified in the char's *.def file. Parsing of the trials data is done by this function and offers future growth functionality. Since the Trials mode is written in Lua, script.go is also modified to allow Lua functions to read the trials data parsed from the trials.def file. Finally, training.zss has a one line change to enable training functionality in Trials mode.

Details on the structure of trials.def files are included in the trials.lua PR (ikemen-engine/modules#3).

@github-actions github-actions bot added the PR: feat This PR implements a new feature label Jul 6, 2024
@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 6, 2024
@two4teezee
Copy link
Contributor Author

Resolved merge conflict... this is ready for review.

@two4teezee two4teezee marked this pull request as ready for review July 6, 2024 18:39
@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 13, 2024
@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 23, 2024
@two4teezee
Copy link
Contributor Author

two4teezee commented Jul 23, 2024

Updated description with links to Universal Trials Mode PR: ikemen-engine/modules#3. It's still in draft as I resolve some of the outstanding issues, but a compiled executable from this PR can be used to test the trials mode module.

@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 26, 2024
@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 27, 2024
@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 28, 2024
@two4teezee two4teezee marked this pull request as draft July 28, 2024 16:26
@two4teezee
Copy link
Contributor Author

two4teezee commented Jul 28, 2024

Threw this back into draft. Adding some functionality as I do testing with more unique characters. Latest updates:

  • Created functionality for checking variable-value pairs to determine whether a trial should be displayed. Useful for characters with grooves or special modes.
  • Added the ability to pause checking for trial steps until the next hit. Useful when mode activation is desired as part of a combo, or at the start of a combo.

@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 29, 2024
@two4teezee
Copy link
Contributor Author

Added var-val pairs on a per-trial step basis to allow for checking var-val pairs during the trial step (separate from the trial display one var-val pairs).

@github-actions github-actions bot added PR: feat This PR implements a new feature and removed PR: feat This PR implements a new feature labels Jul 30, 2024
@two4teezee
Copy link
Contributor Author

This PR is no longer required. Trials mode is now a completely standalone Lua module.

@two4teezee two4teezee closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feat This PR implements a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant